Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception happen when creating multiple ascend-gpu pods concurrently #575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lijm87
Copy link
Contributor

@lijm87 lijm87 commented Oct 25, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: exception occurred while creating multiple pods with ascend gpu concurrently

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/device/ascend/device.go 55.55% 6 Missing and 2 partials ⚠️
Flag Coverage Δ
unittests 27.43% <55.55%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/device/ascend/device.go 11.22% <55.55%> (+8.30%) ⬆️

@lijm87 lijm87 changed the title fix: exception occurred while creating multiple pods with ascend gpu concurrently fix: exception happen when creating multiple ascend-gpu pods concurrently Oct 25, 2024
@archlitchi
Copy link
Collaborator

yes, nodelock is necessary for ascend jobs, but you need to implement 'release lock' part in 'ascend-device-plugin' for it to work

@lijm87
Copy link
Contributor Author

lijm87 commented Oct 31, 2024

yes, nodelock is necessary for ascend jobs, but you need to implement 'release lock' part in 'ascend-device-plugin' for it to work

done. together with PR in 'ascend-device-plugin': Project-HAMi/ascend-device-plugin#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants