Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessary precautions for CuCIM updates #7452

Closed
drbeh opened this issue Feb 8, 2024 · 3 comments
Closed

Necessary precautions for CuCIM updates #7452

drbeh opened this issue Feb 8, 2024 · 3 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@drbeh
Copy link
Member

drbeh commented Feb 8, 2024

CuCIM is a dependency of MONAI for efficiently loading whole slide images and also some GPU accelerated transforms that are being accessed via CuCIM transform in MONAI.

CuCIM has dropped the support for Python 3.8 in the latests versions while MONAI is still supporting it. Currently, the version that we are using in MONAI is cucim==23.10.0 (the latest available on PyPI for this specific package) which supports Python 3.8. However, in order to be able to upgrade to the latest version (which is under different package name), we should first make sure that these CuCIM updates does not affect MONAI functionalities, especially our CI/CD.

@drbeh
Copy link
Member Author

drbeh commented Feb 8, 2024

@aylward
Copy link
Collaborator

aylward commented Feb 9, 2024

My thoughts...

Python 3.8 hits end-of-life in Oct, 2024; so we should discuss if we should continue to support it after that time.

If we drop support for 3.8, there will be a branch that uses the new (renamed) CuCIM package (and has other 3.8 changes in it), and perhaps the Pathology WG can test it in their applications (as real-world tests beyond the CuCIM tests in core). Or did you have something else in mind?

If we don't drop support for 3.8, then perhaps the old CuCIM and the newly renamed version could become optional dependencies - but that should be an exceptional/rare/temporary solution, since testing combinations of optional packages quickly becomes problematic.

Do you think this is something that needs to be addressed for the next release or before Oct 2024?

@KumoLiu KumoLiu added the dependencies Pull requests that update a dependency file label Feb 14, 2024
@KumoLiu
Copy link
Contributor

KumoLiu commented Jul 15, 2024

We have dropped python 3.8 support here: #7909
And also add cucim-cu12 as a dependency here: https://github.com/Project-MONAI/MONAI/blob/dev/requirements-dev.txt#L29

Closing this ticket for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: 💯 Complete
Development

No branches or pull requests

3 participants