Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7908 drop python 3.8 #7909

Merged
merged 2 commits into from
Jul 12, 2024
Merged

7908 drop python 3.8 #7909

merged 2 commits into from
Jul 12, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jul 10, 2024

Fix #7908

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#7908
4f4257b 
Signed-off-by: YunLiu <[email protected]>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 11, 2024

/build

1 similar comment
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 11, 2024

/build

@KumoLiu KumoLiu mentioned this pull request Jul 12, 2024
Closed
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 12, 2024

/build

@KumoLiu KumoLiu merged commit 14b086b into Project-MONAI:dev Jul 12, 2024
28 checks passed
@KumoLiu KumoLiu deleted the drop-38 branch July 12, 2024 12:16
@KumoLiu KumoLiu mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@mingxin-zheng mingxin-zheng Awaiting requested review from mingxin-zheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecating tests for python3.8
2 participants
@KumoLiu @Nic-Ma