Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeler's prop stuck fix #119

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Modeler's prop stuck fix #119

merged 1 commit into from
Aug 14, 2023

Conversation

EpKouhia
Copy link
Contributor

Overview

When selecting housing furniture preview props will get stuck when browsing fast enough, see more here: https://streamable.com/7rmopv

Details

This is a simple fix for ensuring all props are removed if they exist. Would think there would be optional to fix the original issue from UI side as well.

UI Changes / Functionality

No Changes

Testing Steps

Tested with furious scrolling or fast mouse movements multiple times. Could not reproduce the original issue in any way scrolling. Would need more testing due not able to spend too many hours with this. Testing results here: https://streamable.com/mczcua

  • Did you test the changes you made?
  • Did you test core functionality of the script to ensure your changes do not regress other areas?
  • Did you test your changes in multiplayer to ensure it works correctly on all clients?

@LeSiiN
Copy link
Contributor

LeSiiN commented Aug 14, 2023

Works fine, can be merged!

@Hxbble
Copy link

Hxbble commented Aug 14, 2023

Just tested this on my local dev branch. Can confirm it works!

@MonkeyWhisper MonkeyWhisper merged commit 1eb8918 into Project-Sloth:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants