Fixing the incorrect table name in server.lua and updating the README with the solution for the properties.sql import issue. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Ruby-LK Please fix conflicts, will merge after, thanks |
MonkeyWhisper
added
ready for merge
|
Hey, @MonkeyWhisper The conflicts that were present in the readme have been resolved. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR should fix the issue with sql query which calls the wrong table in the db and I have added some details about the solution for the
properties.sqlimport issue : Foreign key constraint is incorrectly formed!Details
As I described in the overview there was a problem in the server.lua (line 115) which calls wrong table :
apartments, instead of thepropertiestable.And I have added an additional part to the readme which tells how to fix that
"Foreign key constraint is incorrectly formed"error.UI Changes / Functionality
Testing Steps
Just download the release and config it as in the readme.
Create a new character and see the server console.
Make sure to use a completely wiped database. (without any previous player data.)
Did you test the changes you made? = Yes
Did you test core functionality of the script to ensure your changes do not regress other areas? = Yes
Did you test your changes in multiplayer to ensure it works correctly on all clients? = Yes