Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Infinite loading screen with decorated houses #186

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

1B0Y
Copy link
Contributor

@1B0Y 1B0Y commented Feb 14, 2024

Overview

As per last few days in #support, myself and a few others have been encountering infinite loading screen when loading into a house that has furniture placed. Common issue we saw was the model was failing to load, and this simply fixes it.

Details

During debugging, I noticed IsModelInCdimage() and IsModelValid() was returning false for certain house objects in random spots of the map. I managed to track down that the ytyp for specific objects was not loaded within those areas - bypass would be to set the YTYP as permament as per method included in the changes.

UI Changes / Functionality

See fxmanifest.lua to see fix

Testing Steps

  1. Check if a model exists by using IsModelValid or IsModelInCdimage
  2. Fly around the map until it turns false
  3. You replicated the issue.
  • Did you test the changes you made?
  • Did you test core functionality of the script to ensure your changes do not regress other areas?
  • Did you test your changes in multiplayer to ensure it works correctly on all clients?

@MonkeyWhisper MonkeyWhisper merged commit 1f44618 into Project-Sloth:main Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants