Dynamic Doors #62
Dynamic Doors #62
Conversation
Video for the Fix CommitBeforeBeforeFix.mp4AfterAfterFix.mp4 |
README.md
Outdated
| https://github.com/complexza/ps-housing/assets/74205343/196bb25e-75b9-42f6-b1c3-fe86ad477544 | ||
|
|
||
| ### Setup | ||
| - You will need to set the `Config.EnableDynanicDoors = true` |
There was a problem hiding this comment.
nit typo: EnableDynamicDoors
| @@ -47,6 +47,18 @@ This will open a furniture store complete with all of the props. Select an item | |||
|
|
|||
| > Note: The place on ground button sometimes does not work properly depending on where the native detects the ground to be. | |||
|
|
|||
| ## Dynamic Doors Preview & Setup | |||
|
|
|||
There was a problem hiding this comment.
nit: maybe just add a note in here on what is meant by dynamic doors (ie: place doros and that they work like a door, rather than a static asset that cant be open/closed)
Side note for future, it might even be cool to see if we can make some of these interior doors lockable (i wonder if it would work with the existing doorlock systems when you place a door down??)
There was a problem hiding this comment.
That would be something to look into for the near future I think, That wouuld be pretty sick!
|
|
||
| ### Setup | ||
| - You will need to set the `Config.EnableDynanicDoors = true` | ||
| - You will have to add this convar into your server.cfg `setr game_enableDynamicDoorCreation "true"` |
There was a problem hiding this comment.
Curious, why is this convar needed?
There was a problem hiding this comment.
I am actually not sure, I just knows it makes the doors dynamic, as far as I know the convar just converts the doors into the dynamic mode
There was a problem hiding this comment.
Added game_enableDynamicDoorCreation network check bypass, allowing the creation of doors dynamically in a network environment (thanks to @Nikez, @z3t4s, and okqut).
I found this when it was added https://forum.cfx.re/t/cfx-re-community-pulse-june-2023-edition/5109543
There was a problem hiding this comment.
ohh sick! Thanks, I struggled to find docs on it!
Co-authored-by: BackSH00TER <[email protected]>
|
Last Commit |
ui/src/components/OwnedItems.svelte
Outdated
| @@ -34,23 +34,24 @@ | |||
| class="bg-[color:var(--color-tertiary)] text-[2rem] w-[4rem] h-[4rem] text-center aspect-square" | |||
| on:click={() => { | |||
| SendNUI('selectOwnedItem', item) | |||
| console.log(item.type) | |||
ui/src/components/OwnedItems.svelte
Outdated
| <i class="fa-solid fa-xmark" /> | ||
| </button> | ||
| {/if} | ||
| {#if item.type != 'storage' && item.type != 'clothing'} |
There was a problem hiding this comment.
If we add more item types (which I'm sure we will), this won't be very extensible and we'll potentially need to keep adding all the item types here to exclude.
@ImXirvin what was the original intention behind this check. It seems like its just to prevent them from removing the Wardrobe or Storage furniture items. Is that really necessary? I'm almost thinking we remove the conditional entirely and just show the remove furniture button on everything
There was a problem hiding this comment.
That is true, If Xirvin says the check isn't really necessary, I think it might be better removing that whole check!
There was a problem hiding this comment.
@complexza ya, lets just remove that check, make everything removeable.
if someone removes their stash, they'll just have to replace it again to access the items, but it shouldnt even have any effects of data loss since the stuff for creating/opening inventory is al separate, the storage items is just the means to open it
Overview
Dynamic Doors are cool, Allows you to actually use doors and they automatically work.
Details
You can basically open and close the doors when you place them as furniture.
Video
DynamicDoorsOn.mov
DynamicDoorsOff.mov
UI Changes / Functionality
Include a before and after screenshot/recording if applicable. Short recordings showing that your changes work are helpful, but optional. None
Testing Steps
Provide a list of repro steps on how to test that your changes are valid.