Added Required Item (police_stormram) For Raid #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Overview *Provide a brief overview of the purpose of this pull request* - Requires police to have the storm ram item in order to begin the raiding process. # Details *Provide details on the change you are making, why they are necessary, and any information that will help with understanding.* - This is really only a QoL update to help keep immersion in roleplay. # UI Changes / Functionality *Include a before and after screenshot/recording if applicable. Short recordings showing that your changes work are helpful, but optional.* - Not Applicable # Testing Steps *Provide a list of repro steps on how to test that your changes are valid.* - Attempt raid on owned property without storm ram results in Notification that the item is necessary. - Having the item begins Raid as normal, and removes the item from the inventory. - [Yes ] Did you test the changes you made? - [Yes ] Did you test core functionality of the script to ensure your changes do not regress other areas? - [Yes ] Did you test your changes in multiplayer to ensure it works correctly on all clients?
LeSiiN
added
needs testing
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Provide a brief overview of the purpose of this pull request
Details
Provide details on the change you are making, why they are necessary, and any information that will help with understanding.
UI Changes / Functionality
Include a before and after screenshot/recording if applicable. Short recordings showing that your changes work are helpful, but optional.
Testing Steps
Provide a list of repro steps on how to test that your changes are valid.
To Do
Add ps-ui export for use of storm ram
[Yes ] Did you test the changes you made?
[Yes ] Did you test core functionality of the script to ensure your changes do not regress other areas?
[Yes ] Did you test your changes in multiplayer to ensure it works correctly on all clients?