Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Doors being Limited #97

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Fix for Doors being Limited #97

merged 6 commits into from
Aug 10, 2023

Conversation

complexza
Copy link
Member

Overview

Doors were being limited to only 1

Details

Added a check to exclude doors

Testing Steps

Tested with myself & LeSiiN we both found it working perfectly @LeSiiN

  • Did you test the changes you made?
  • Did you test the core functionality of the script to ensure your changes do not regress other areas?
  • Did you test your changes in multiplayer to ensure it works correctly on all clients?

image

image

@complexza
Copy link
Member Author

a new PR cause I messed up. Reference to old PR #73

@complexza
Copy link
Member Author

Needs to change where if you try and buy more then the max index it will stop you.

@complexza complexza added enhancement New feature or request and removed needs testing labels Aug 3, 2023
@LeSiiN LeSiiN added ready for merge Reviewed and can be merged to main and removed enhancement New feature or request labels Aug 4, 2023
BackSH00TER
BackSH00TER approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@BackSH00TER BackSH00TER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two final nits, otherwise looks good

ui/src/components/ItemList.svelte Outdated Show resolved Hide resolved
ui/src/components/Modeler.svelte Outdated Show resolved Hide resolved
@BackSH00TER BackSH00TER merged commit 7dd15cb into Project-Sloth:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BackSH00TER BackSH00TER BackSH00TER approved these changes

Assignees
No one assigned
Labels
ready for merge Reviewed and can be merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@complexza @BackSH00TER @LeSiiN