Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Search for vehicle missing from vehicles.lua causes DMV search to get stuck #437

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

BackSH00TER
Copy link
Contributor

Bug: If you search for a vehicle that is not defined in the vehicles.lua file, the DMV search will get stuck with an infinite spinner. Users are not able to get the DMV search back into a good state and are forced to relog.
image
image

Fix: Adding a similar log message like we have in a different place. We first check that the vehData exists before trying to get the brand and model off of vehData. If it does not exist, we set it to UNKNOWN.

This check makes it so we do not brick the DMV search. Users can then share the F8 console error message with the server to alert them of vehicles that need to be added.

After the fix an unknown vehicle search result will look like:
image

@BackSH00TER BackSH00TER added the bug Something isn't working label Dec 11, 2023
@MonkeyWhisper
Copy link
Member

Tested and fully working

@MonkeyWhisper MonkeyWhisper merged commit 0733455 into Project-Sloth:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants