Bug fix: Search for vehicle missing from vehicles.lua causes DMV search to get stuck #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and fully working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: If you search for a vehicle that is not defined in the vehicles.lua file, the DMV search will get stuck with an infinite spinner. Users are not able to get the DMV search back into a good state and are forced to relog.
Fix: Adding a similar log message like we have in a different place. We first check that the vehData exists before trying to get the brand and model off of vehData. If it does not exist, we set it to UNKNOWN.
This check makes it so we do not brick the DMV search. Users can then share the F8 console error message with the server to alert them of vehicles that need to be added.
After the fix an unknown vehicle search result will look like:
