Fix people search on the incidents, bolos, reports pages #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When you search for people on the Incidents, BOLOs, or Reports pages, the search requires that you search either FirstName LastName or FIrstName. If you try to search just LastName the search will fail.
When you search for people on the Profile search page, you are able to search with any combination to find people (FirstName, First + Last, Last, citizenId, fingerprint, etc).
This PR makes the search on these sub pages function the same way. Now players will have more flexibility in how they input their search terms and will be able to find results easier.
The fix simply updates the SQL query to use the same terms that the Profile search query is using.
Preview of fix:
