Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/upgrade greenwood v0.30.0 #22

Merged
merged 15 commits into from
Nov 2, 2024
Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 16, 2023

  1. testing for enhancement/Issue-1118: Single File Bundles for SSR and API routes greenwood#1186
    • including support for more forgiving WCC customElements.get assuming tagName exists automatically
  2. testing for enhancement/upgrade to WCC v0.10.0 with spec compliant support shadowrootmode attribute support greenwood#1195
  3. SFE refactoring introduced an infinite loop in local server SSR pages? 😬
  4. test with latest alpha
  5. error for missing acorn-jsx package wcc#150
  6. bug/ensure minimum compatible version of wcc 0.12.1 greenwood#1209
  7. (nice to have / new issue) Migrate to Constructable Stylesheets - adopt usage of Constructable Stylesheets #29
    • requires vercel <> NodeJS version compat?

Copy link

vercel bot commented Dec 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
greenwood-demo-adapter-vercel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 5:01pm

@thescientist13
Copy link
Member Author

Hmm, getting some sort of infinite loop issue with this upgrade?

Steps

  1. npm run clean && npm run serve
  2. Load Products page
  3. Load home page and click load products button
  4. Load search page and search (e.g. _phone)
  5. Load Products page
  • Expected: it should load
  • Actual: page loading hangs and eventually crashes when the server breaks
    • if you see the terminal output, fetching products will have run 110 times, before I think we get rate limited by the placeholder API
greenwood-sfe-ssr-infinite-loop.mov

@thescientist13 thescientist13 marked this pull request as ready for review November 2, 2024 17:01
@thescientist13 thescientist13 merged commit 659115e into main Nov 2, 2024
2 checks passed
@thescientist13 thescientist13 deleted the chore/upgrade-greenwood-0.30.0 branch November 2, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant