Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use DOMParser before injecting Fragments API responses in the DOM #25

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jan 3, 2024

Per ProjectEvergreen/wcc#130, this resolves the warnings being seen in Chrome around injecting DSD from backend APIs.

Screenshot 2024-01-03 at 12 29 30 PM


  1. Should apply this to the Netlify demo repo as well - enhancement/misc DSD refactoring greenwood-demo-adapter-netlify#17

@thescientist13 thescientist13 added the enhancement New feature or request label Jan 3, 2024
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
greenwood-demo-adapter-vercel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2024 6:47pm

@thescientist13 thescientist13 changed the title use DOMParser before injecting Fragments API responses use DOMParser before injecting Fragments API responses in the DOM Jan 3, 2024
@thescientist13 thescientist13 force-pushed the enhancement/use-dom-parser-for-injecting-HTML-API-fragments branch from 2413b40 to 40eb1d5 Compare January 6, 2024 18:47
@thescientist13 thescientist13 merged commit 81c969c into main Jan 6, 2024
2 checks passed
@thescientist13 thescientist13 deleted the enhancement/use-dom-parser-for-injecting-HTML-API-fragments branch January 6, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant