Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore strict mode compatibility for Greenwood website #410

Closed
1 of 5 tasks
thescientist13 opened this issue Aug 6, 2020 · 1 comment
Closed
1 of 5 tasks

explore strict mode compatibility for Greenwood website #410

thescientist13 opened this issue Aug 6, 2020 · 1 comment
Labels
chore unit testing, maintenance, etc question Further information is requested website Tasks related to the projects website / documentation

Comments

@thescientist13
Copy link
Member

thescientist13 commented Aug 6, 2020

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Related to the work done in #396 as part of #354 with the introduction of the optimization configuration option , would like to explore the feasibility of making the Greenwood website work using strict.

Details

The main consideration things that I can think of that would need to be addressed

  1. The banner rotation rotation on the home page would need to be moved into inline <script> tags
  2. The shelf sub nav would need to work without LitElement @click event handler
  3. There are usages of custom elements being uses as CSS selectors which will not work

Maybe convert it to Lit+SSR with hydration for the progressive hydration for just the navigation?


That said, the above all make great criteria for proving the idea of Progressive Enhancement in that we only pass through userland code without the SPA bundling, but I'm also curious just to see what it would take, even if the PR doesn't get merged for strict mode in the Greenwood website. I guess it depends on what comes first. 😄

@thescientist13 thescientist13 added question Further information is requested website Tasks related to the projects website / documentation labels Aug 6, 2020
@thescientist13 thescientist13 added this to the 1.0 milestone Apr 11, 2021
@thescientist13 thescientist13 removed this from the 1.0 milestone Mar 15, 2022
@thescientist13 thescientist13 added the chore unit testing, maintenance, etc label Mar 15, 2022
@thescientist13
Copy link
Member Author

We're doing an overhaul of the website as part of #978 so can close this out.

@thescientist13 thescientist13 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore unit testing, maintenance, etc question Further information is requested website Tasks related to the projects website / documentation
Projects
Development

No branches or pull requests

1 participant