-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/issue 546 optimization overrides #645
Enhancement/issue 546 optimization overrides #645
Conversation
As far as this commit where Using dev tools, what I could see is that global styles where inheriting into this element. which is what was causing the undesired padding. Which makes sense, since the footer.css uses / assumes ShadowDOM and usage of app-footer .footer.app-footer {
background-color: #192a27; min-height: 30px; padding-top: 10px;
}
app-footer .footer.app-footer h4.app-footer {
width: 90%; margin: 0 auto; padding: 0; text-align: center;
}
app-footer .footer.app-footer a.app-footer {
color: white; text-decoration: none;
} This means that no encapsulation can be guaranteed, so in some cases, so additional consideration / tweaks may be needed, like using |
Just a heads up here re: #652 |
Did a before / after comparison. Lighthouse scores are about the same, but we can definitely shave off a few network requests and bring down our payload size by ProductionDeploy Preview (permalink) |
c0ec0d4
to
9539cd4
Compare
Related Issue
resolves #546
Summary of Changes
static
andinline
optimization overrides for<script>
tagsinline
optimization overrides for<link>
tagsnone
override will have to come laterTODOs
clean up / remove override attributes from final HTMLnone of the options we support keep the original tag, hence the attributes are not present, so nothing to do here reallyTODO
s