Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default <meta> tags are missing from default app template in 0.10.0-alpha.0 #446

Closed
1 of 5 tasks
thescientist13 opened this issue Dec 13, 2020 · 0 comments · Fixed by #474
Closed
1 of 5 tasks

default <meta> tags are missing from default app template in 0.10.0-alpha.0 #446

thescientist13 opened this issue Dec 13, 2020 · 0 comments · Fixed by #474
Assignees
@thescientist13
Labels
alpha.7 bug Something isn't working CLI good first issue Good for newcomers P0 Critical issue that should get addressed ASAP v0.10.0
Milestone
No Bundle Feature...

Comments

@thescientist13
Copy link
Member

thescientist13 commented Dec 13, 2020 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Compared to previous app-template.js, looks like this default meta is missing

<meta charset='utf-8'>
<meta name='viewport' content='width=device-width, initial-scale=1'/>
<meta name='mobile-web-app-capable' content='yes'/>
<meta name='apple-mobile-web-app-capable' content='yes'/>
<meta name='apple-mobile-web-app-status-bar-style' content='black'/>

Details

Should be restored to new app.html template and some tests should probably be added to the default test case.
@thescientist13 thescientist13 added bug Something isn't working CLI good first issue Good for newcomers labels Dec 13, 2020
@thescientist13 thescientist13 changed the title default meta missing from default app template in 0.10.0-alpha.0 default <meta> tags are missing from default app template in 0.10.0-alpha.0 Dec 13, 2020
@thescientist13 thescientist13 mentioned this issue Dec 13, 2020
Merged
11 tasks
@thescientist13 thescientist13 mentioned this issue Dec 21, 2020
Merged
22 tasks
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Dec 29, 2020
@thescientist13 thescientist13 self-assigned this Feb 13, 2021
@thescientist13 thescientist13 mentioned this issue Feb 13, 2021
Merged
@thescientist13 thescientist13 linked a pull request Feb 13, 2021 that will close this issue
restore default meta tags and update website #474
Merged
@thescientist13 thescientist13 mentioned this issue Feb 27, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
alpha.7 bug Something isn't working CLI good first issue Good for newcomers P0 Critical issue that should get addressed ASAP v0.10.0
Projects
None yet
Milestone
No Bundle Feature Parity
Development

Successfully merging a pull request may close this issue.

restore default meta tags and update website ProjectEvergreen/greenwood
1 participant
@thescientist13