-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/upgrade greenwood 0.10.0 #182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
Article on FOUC + Lighthouse |
thescientist13
force-pushed
the
enhancement/upgrade-greenwood-0.10.0
branch
from
December 30, 2020 22:43
11e16c8
to
196383a
Compare
thescientist13
force-pushed
the
enhancement/upgrade-greenwood-0.10.0
branch
from
March 20, 2021 17:33
b88084d
to
a5ee592
Compare
thescientist13
commented
Mar 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was referenced Mar 20, 2021
Merged
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3.0.0
Greenwood v0.10.0-alpha.8 upgrade and go live
chore
build stuff, deploy stuff, etc etc
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This starts the process of migrating to an upcoming (significant) version of Greenwood for 0.10.0 release.
https://github.com/ProjectEvergreen/greenwood/releases/tag/v0.10.0-alpha.4
Changes
serve
npm script to usegreenwood serve
Already hitting! 💯
Known Issues / TODO
<slot>
s - instances of <slot>-ed content and lit-element are rendering twice ProjectEvergreen/greenwood#433devServer
configuration (should be supported already?) - N / A, deprecatedoptimization
, or turn it off until until CSS in JS can be undone in the project? (deferred to restore optimization settings / final 0.10.0 upgrade #184) - Progressive Enhancement ("RedactJS") ProjectEvergreen/greenwood#354<meta>
- default <meta> tags are missing from default app template in 0.10.0-alpha.0 ProjectEvergreen/greenwood#446<meta>
still, poor Lighthouse scoreemoji on home page is borked:/ - fixed by upgrading to Node v14? - created wave emoji on home page doesn't render on localyarn serve
#192TODOs / New Issues (for the project, not this PR)
strict
optimization mode, it will fail - made move away from CSS-in-JS solution and go all in on regular CSS #185~90k
. Should find a way to see if this can be improved further, either through more compression or some HTML attributes - made further improve compression / performance of banner image #187<app-blog-post-details>
in post.html instead of having a post.js, probably depends on getting this solve so we can reference../
paths in page templates? Otherwise, relative paths within relatives paths not working right now - resolve (deeply) nested relative template paths to expected workspace path ProjectEvergreen/greenwood#435 .... or - made refactor post template to use blog post details directly from template #188import
from within markdown front matter, i could reuse the same page.html template, then I wouldn't need a custom page template just for one offs like about or projects, that just need markdown + a single custom element. I think this will need support from resolve (deeply) nested relative template paths to expected workspace path ProjectEvergreen/greenwood#435 - made refactor post template to use blog post details directly from template #188<link>
tags that reference remote URLs break the build (v0.10.0 alpha) ProjectEvergreen/greenwood#491