Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an SSR mode for Greenwood #708

Closed
1 of 5 tasks
thescientist13 opened this issue Aug 31, 2021 · 0 comments · Fixed by #838, #868 or #875
Closed
1 of 5 tasks

Introduce an SSR mode for Greenwood #708

thescientist13 opened this issue Aug 31, 2021 · 0 comments · Fixed by #838, #868 or #875
Assignees
Labels
alpha.0 CLI documentation Greenwood specific docs feature New feature or request question Further information is requested SSR v0.23.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Aug 31, 2021

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As part of ongoing discovery in #576 , one the key action items needed is to enable a true SSR mode that will allow running Greenwood as a process on a server such that at least for the serve command, will effectively just run the koa server to generate pages / templates on the fly but serving bundled rollup code.

Details

Basically we need to add ssr as a mode such when a user runs npm run serve, we build and bundle all the pages and assets like normal, but additionally keep the Koa server going to keep serving requests to pages and content but in a built / production context.

We might also want to rename the current serve command to a demo since now server will require a special set of expectations on its own that should be specifically find tuned for running on a server as a process.

Thoughts / questions

  1. Server side rendering support for local development?
  2. Still need to explore a bit more how server side templating and data fetching would work
  3. Now that we need Koa for more than a dev server, should explore using something like fastify?
  4. Should we persist puppeteer in this scenario? Making this something like an optionalDependency would be amazing and only install it on demand when needed / detected
  5. Should we think about re-branding Greenwood at this point, since it won't just be an SSG anymore?
@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) documentation Greenwood specific docs CLI SSR labels Aug 31, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Aug 31, 2021
@thescientist13 thescientist13 self-assigned this Aug 31, 2021
@thescientist13 thescientist13 changed the title Introduce an SSR mode via Greenwood configuration Introduce an SSR mode for Greenwood Aug 31, 2021
@thescientist13 thescientist13 added the question Further information is requested label Aug 31, 2021
@thescientist13 thescientist13 pinned this issue Oct 16, 2021
@thescientist13 thescientist13 mentioned this issue Nov 3, 2021
5 tasks
@thescientist13 thescientist13 linked a pull request Feb 2, 2022 that will close this issue
@thescientist13 thescientist13 added feature New feature or request and removed enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Feb 9, 2022
@thescientist13 thescientist13 unpinned this issue Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.0 CLI documentation Greenwood specific docs feature New feature or request question Further information is requested SSR v0.23.0
Projects
None yet
1 participant