Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration for prod server port #875

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 2, 2022

Related Issue

#708

Question: Should we make develop default port something more familiar like 3000? - leaving it at 1984 😄

Summary of Changes

  1. Added the ability to customize server port
  2. Added docs and serve spec

@thescientist13 thescientist13 added documentation Greenwood specific docs CLI alpha.1 feature New feature or request v0.23.0 labels Feb 2, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Feb 2, 2022
@thescientist13 thescientist13 linked an issue Feb 2, 2022 that may be closed by this pull request
5 tasks
Copy link
Member

@hutchgrant hutchgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thescientist13 thescientist13 force-pushed the feature/issue-708-configure-prod-server-port branch from 45cc453 to 6307be5 Compare February 5, 2022 00:44
@thescientist13 thescientist13 merged commit f00153e into release/0.23.0 Feb 5, 2022
@thescientist13 thescientist13 deleted the feature/issue-708-configure-prod-server-port branch February 5, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.1 CLI documentation Greenwood specific docs feature New feature or request v0.23.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce an SSR mode for Greenwood
2 participants