-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 948 web api standardization #1045
Merged
thescientist13
merged 50 commits into
release/0.28.0
from
feature/issue-948-web-api-standardization
Feb 5, 2023
Merged
Feature/issue 948 web api standardization #1045
thescientist13
merged 50 commits into
release/0.28.0
from
feature/issue-948-web-api-standardization
Feb 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
documentation
Greenwood specific docs
Plugins
Greenwood Plugins
CLI
feature
New feature or request
labels
Jan 18, 2023
thescientist13
added
RFC
Proposal and changes to workflows, architecture, APIs, etc
and removed
feature
New feature or request
labels
Jan 27, 2023
3 tasks
3 tasks
thescientist13
force-pushed
the
feature/issue-948-web-api-standardization
branch
from
February 5, 2023 01:02
eaa10a5
to
a2eefc6
Compare
thescientist13
added a commit
that referenced
this pull request
Feb 7, 2023
* web standard APIs adoption * update graph lifecyle to work with URLs * web standards refactoring for Resource plugins resolve lifecycle * refactoring develop command and serve resource lifecycle for standard plugins * refactor standard plugin intercept lifecycle * clean up * restore app templating to standard HTML resource plugin * WIP refactoring plugins for web standardization * handle develop command middleware support for handling binary or text response types * restore nested relative routes resolution and general standard plugin refactoring * group greenwood plugins * adapt intercept lifecycles for web standards signature * adapt pre-render build lifecycle and refactor page serving and intercepting * refactor build and optimize lifecycles * refactor bundle and optimize lifecycles * restore cleanupResources * restore copy lifecyle and all of build command * restore serve command and full website prerendering * restore specs and fixing missed upgrades * all CLI specs passing * all core specs and plugins working * getting package plugin specs passing * getting package plugin specs passing * getting package plugin specs passing * getting package plugin specs passing * all plugin specs passing * update spec for content type * exp CSS import specs passing * exp JSON import specs passing * clean up console logs * resolve max listeners warning * restore E-Tag middleware for development * merged response bundling working * restore optimized graphql behavior * update docs * fix specs * clean up TODOs * docs revisions * windows compat with fs.promises and URL * develop command working * convert to fs.promises * build and serve refactored to fs.promises and URL * all specs passing except for APIs * all specs passing yay * temp disable linting * commands and almost all specs passing, phew * refactor fs.access and fix lint * restore linting to github actions * resource and utils refactoring * TODOs cleanup and tracking
thescientist13
added a commit
that referenced
this pull request
Apr 9, 2023
* web standard APIs adoption * update graph lifecyle to work with URLs * web standards refactoring for Resource plugins resolve lifecycle * refactoring develop command and serve resource lifecycle for standard plugins * refactor standard plugin intercept lifecycle * clean up * restore app templating to standard HTML resource plugin * WIP refactoring plugins for web standardization * handle develop command middleware support for handling binary or text response types * restore nested relative routes resolution and general standard plugin refactoring * group greenwood plugins * adapt intercept lifecycles for web standards signature * adapt pre-render build lifecycle and refactor page serving and intercepting * refactor build and optimize lifecycles * refactor bundle and optimize lifecycles * restore cleanupResources * restore copy lifecyle and all of build command * restore serve command and full website prerendering * restore specs and fixing missed upgrades * all CLI specs passing * all core specs and plugins working * getting package plugin specs passing * getting package plugin specs passing * getting package plugin specs passing * getting package plugin specs passing * all plugin specs passing * update spec for content type * exp CSS import specs passing * exp JSON import specs passing * clean up console logs * resolve max listeners warning * restore E-Tag middleware for development * merged response bundling working * restore optimized graphql behavior * update docs * fix specs * clean up TODOs * docs revisions * windows compat with fs.promises and URL * develop command working * convert to fs.promises * build and serve refactored to fs.promises and URL * all specs passing except for APIs * all specs passing yay * temp disable linting * commands and almost all specs passing, phew * refactor fs.access and fix lint * restore linting to github actions * resource and utils refactoring * TODOs cleanup and tracking
thescientist13
added a commit
that referenced
this pull request
Apr 9, 2023
* web standard APIs adoption * update graph lifecyle to work with URLs * web standards refactoring for Resource plugins resolve lifecycle * refactoring develop command and serve resource lifecycle for standard plugins * refactor standard plugin intercept lifecycle * clean up * restore app templating to standard HTML resource plugin * WIP refactoring plugins for web standardization * handle develop command middleware support for handling binary or text response types * restore nested relative routes resolution and general standard plugin refactoring * group greenwood plugins * adapt intercept lifecycles for web standards signature * adapt pre-render build lifecycle and refactor page serving and intercepting * refactor build and optimize lifecycles * refactor bundle and optimize lifecycles * restore cleanupResources * restore copy lifecyle and all of build command * restore serve command and full website prerendering * restore specs and fixing missed upgrades * all CLI specs passing * all core specs and plugins working * getting package plugin specs passing * getting package plugin specs passing * getting package plugin specs passing * getting package plugin specs passing * all plugin specs passing * update spec for content type * exp CSS import specs passing * exp JSON import specs passing * clean up console logs * resolve max listeners warning * restore E-Tag middleware for development * merged response bundling working * restore optimized graphql behavior * update docs * fix specs * clean up TODOs * docs revisions * windows compat with fs.promises and URL * develop command working * convert to fs.promises * build and serve refactored to fs.promises and URL * all specs passing except for APIs * all specs passing yay * temp disable linting * commands and almost all specs passing, phew * refactor fs.access and fix lint * restore linting to github actions * resource and utils refactoring * TODOs cleanup and tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
CLI
documentation
Greenwood specific docs
Plugins
Greenwood Plugins
RFC
Proposal and changes to workflows, architecture, APIs, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #948 / #949
Summary of Changes
URL
/Request
/Response
TODOs
Request.clone
/Response.clone
, as it seems to cause this issue(node:81167) MaxListenersExceededWarning: Possible EventTarget memory leak detected. 11 abort listeners added to [AbortSignal]. Use events.setMaxListeners() to increase limit
develop
commandResourceInterface
(extensions, lifecycle signatures, util methods)convert node modules lib to useURL
convert the graph lifecycle to use(maybe as part of bundle and optimize server and API routes and serve from output directory (decoupleURL
serve
task from source code) #946 ?)how to handle- handle defaultResponse
already setting a defaultContent-Type
oftext/plain;charset=UTF-8
Content-Type
being set in defaultResponse
instances #1049convert allfs
usage tofs.promises
+URL
Figure out consistent usage- added to make Greenwood CLI and pluginsfs
and sync / async version for things like.map
,.filter
async
through and through #823flesh out all remaining- handle merging additionalResponse
properties inmergeResponse
Request
/Response
instance properties #1048- tracking in the backlogContent-Type
vscontent-type
consistency ?refactor outresolveForRelativeUrl
from ResourceInterfacerefactor out find package.jsonremove unusedthis.extensions
refactor rollup.config.jsresolveId
to usethis.resolveRelativeUrl
from ResourceInterfaceconvert to Fastify, or something that can handle a native- added to BacklogResponse
object?<script>
tag with a path of/undefined
(when an SSR route is present?) #1051<script>
tag not closing for inline + none optimizations, like for Google Analytics? (GFI) - <script> tags using optimization attributes have a space before the closing bracket of the opening tag #1052