Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/conditionally check Response object properties and values in development and serve lifecycles #1131

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Aug 2, 2023

Related Issue

resolves #1130

Summary of Changes

  1. Don't assume values of methods on the Response object
  2. Don't don't assume the body of a Response object

More comprehensive response handling coming as part of #1048

@thescientist13 thescientist13 added bug Something isn't working Plugins Greenwood Plugins CLI labels Aug 2, 2023
@thescientist13 thescientist13 changed the title bug/conditionally check Response object method values in development and serve lifecycles bug/conditionally check Response object method values in development and serve lifecycles Aug 2, 2023
@thescientist13 thescientist13 changed the title bug/conditionally check Response object method values in development and serve lifecycles bug/conditionally check Response object properties and values in development and serve lifecycles Aug 2, 2023

it('should return a 200 status', function(done) {
expect(response.statusCode).to.equal(200);
console.log('???', response.body);

This comment was marked as outdated.

@thescientist13 thescientist13 force-pushed the bug/issue-1130-graceful-response-properties-handling branch from 1777d3e to 43096a2 Compare August 3, 2023 01:23
@thescientist13 thescientist13 merged commit 613b54f into master Aug 3, 2023
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1130-graceful-response-properties-handling branch August 3, 2023 01:59
@@ -37,7 +37,7 @@ describe('Serve Greenwood With: ', function() {
this.context = {
hostname
};
runner = new Runner();
runner = new Runner(true);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI Plugins Greenwood Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minimal Response throws errors in development and production lifecycles
1 participant