Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1118 SSR pages are missing URL chunks of route chunk #1210

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Mar 10, 2024

Related Issue

regression from #1118

Noticed during upgrade testing that Rollup still seemed to be generating chunks of chunks and that ultimately these were not being tracked as part of Adapter code
thescientist13/greenwood-lit-ssr#12
Screenshot 2024-03-10 at 7 13 59 PM

We can see that a chunk for lit-element was created, which belongs to the products.route.js entry point

And it was not in the Vercel build output
Screenshot 2024-03-10 at 7 17 12 PM
Screenshot 2024-03-10 at 7 17 28 PM

Summary of Changes

  1. Copy over missing related route chunks by namespacing SSR page entry points and chunks

TODO

  1. Need to fix the issue for good with a better convention
  2. Apply to Netlify implementation
  3. Find a better way to reproduce this in test cases

@thescientist13 thescientist13 added bug Something isn't working CLI Adapter labels Mar 10, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Mar 10, 2024
@thescientist13 thescientist13 changed the title bug/issue 1118 SSR pages are missing chunks of route chunk bug/issue 1118 SSR pages are missing URL chunks of route chunk Mar 13, 2024
@thescientist13 thescientist13 marked this pull request as ready for review March 13, 2024 02:31
@thescientist13 thescientist13 mentioned this pull request Mar 16, 2024
39 tasks
@thescientist13 thescientist13 force-pushed the bug/issue-1118-ssr-pages-missing-chunks-of-route-chunk branch from c031102 to 4592e6c Compare March 16, 2024 23:14
@thescientist13 thescientist13 merged commit 1eb5fbf into release/0.30.0 Mar 16, 2024
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1118-ssr-pages-missing-chunks-of-route-chunk branch March 16, 2024 23:30
thescientist13 added a commit that referenced this pull request Jun 1, 2024
* naive work around for missing chunks of route chunk

* fix linting

* namespace SSR page route entry points and route chunks
thescientist13 added a commit that referenced this pull request Nov 2, 2024
* naive work around for missing chunks of route chunk

* fix linting

* namespace SSR page route entry points and route chunks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant