-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc/issue 1167 content as data #1266
Draft
thescientist13
wants to merge
25
commits into
release/0.30.0
Choose a base branch
from
rfc/issue-1167-content-as-data
base: release/0.30.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,201
−2,501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
question
Further information is requested
RFC
Proposal and changes to workflows, architecture, APIs, etc
CLI
Content as Data
breaking
feature
New feature or request
labels
Aug 11, 2024
16 tasks
thescientist13
added
the
website
Tasks related to the projects website / documentation
label
Aug 24, 2024
15 tasks
thescientist13
force-pushed
the
rfc/issue-1167-content-as-data
branch
from
September 6, 2024 21:45
b809f51
to
e916c3f
Compare
19 tasks
thescientist13
force-pushed
the
rfc/issue-1167-content-as-data
branch
from
September 21, 2024 17:50
44e7864
to
a070bc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
CLI
Content as Data
documentation
Greenwood specific docs
feature
New feature or request
question
Further information is requested
RFC
Proposal and changes to workflows, architecture, APIs, etc
website
Tasks related to the projects website / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #1167
Summary of Changes
TODOs
interpolateFrontmatter
->activeFrontmatter
renamelinkheadings
->toc
What is the meaningful difference between- better generatedid
andlabel
?path
andfilename
? anything else worth cleaning up?id
, and gave better definitions to everything elseRenameindex
->order
renamemenu
->collection
defaulttitle
andlabel
should be the same and actually meaningful)Changepath
->url
(instance of URL or at least thehref
property for serializing)Something more predictable for- renamed tooutputPath
outputHref
it (- see nested SSR pages (and API routes) are throwing a module not found error (needs additional patch for adapters) #1223id
) doesn't "scale", e.g. for nested pagestitle
not populating as active frontmatter (is this because we set it tonull
?)unshift
on content as data in the graph?activeFrontmatter
when rendering page layout<title>
data
,route
, ???)+= 1
develop
specs?renameinterpolateFrontmatter
->activeFrontmatter
${graph.page.data.foo}
Response
merging isn't working?basePath
build graphQL resolvers off of greenwood internal functions / content API endpoint- I think would rather wait until support hot reloading content as data changes during development #1278Thoughts / Observations
globalThis
?fetch
requests, e.g.<script type="application/json" GWD-DATA ...></script>
graph
topages
instead? A graph implies nodes, some sort of linking structure, etc which it is definitely not in its current state.prerender
vs SSR vs CSR) #951prerender
caveat - only your components run once, not your generic inline<script>
tags!<script type="application/json">
data-gwd-opt="static"
, should we create something likeuse static
? 🤔<my-heading><h1>Hello World!</h1></my-heading>
-><h1>Hello World!</h1>
🤔 🤔outputDir
,scratchDir
,userWorkspace
and append HrefoptimizedFileName
, etc