bug/issue 1197 ensure Lit SSR hydration script loads after importmaps #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
force-pushed
the
bug/issue-1197-hydration-script-tag-loading-before-importmaps
branch
from
a6e2b8f
to
948158a
Compare
thescientist13
deleted the
bug/issue-1197-hydration-script-tag-loading-before-importmaps
branch
thescientist13
added a commit
that referenced
this pull request
Nov 2, 2024
…#1289) * ensure Lit hydration script loads after importmaps * fix attribute selector syntax used in test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
related to #1197
Noticed in thescientist13/greenwood-lit-ssr#14 that Chrome started complaining that
<script type="module">tags are not allowed before a<script type="importmap">(which makes sense)Summary of Changes