Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/issue 953 support for Bun #1308

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 9, 2024

Related Issue

related to #953

See a userland example here - https://github.com/thescientist13/greenwood-bun

Documentation

TBD

Summary of Changes

  1. Add GitHub Actions for Bun

TODO

  1. Add a PR to the website (home page, hosting, etc) (assuming all actions pass)
    • callout needing trustedDependencies to support postinstall scripts with Bun, like for the puppeteer plugin
  2. Not sure if we should validate compat with migrate to register function for NodeJS custom imports (no more flag!) #1220

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) documentation Greenwood specific docs CLI labels Nov 9, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 9, 2024
@thescientist13 thescientist13 changed the title add github actions for bun feature/issue 953 validate support for Bun Nov 9, 2024
@thescientist13 thescientist13 added feature New feature or request question Further information is requested and removed enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Nov 9, 2024
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, I spoke too soon :/

I forgot that our NPM scripts still call out to node lol, so of course when I removed that and run bun run build it fails lol

Initializing active content...
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".svg" for /Users/owenbuckley/Workspace/project-evergreen/www.greenwoodjs.dev/src/assets/discord.svg
    at new NodeError (node:internal/errors:405:5)
    at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:136:11)
    at defaultGetFormat (node:internal/modules/esm/get_format:182:36)
    at defaultLoad (node:internal/modules/esm/load:101:20)
    at ModuleLoader.load (node:internal/modules/esm/loader:417:13)
    at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:288:22)
    at new ModuleJob (node:internal/modules/esm/module_job:63:26)
    at #createModuleJob (node:internal/modules/esm/loader:312:17)
    at ModuleLoader.getJobFromResolveResult (node:internal/modules/esm/loader:265:34)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:251:17) {
  code: 'ERR_UNKNOWN_FILE_EXTENSION'
}

So seems like some sort of adapter would be needed for this then. 😞

I guess we would have to implement a plugin somehow?
https://bun.sh/docs/bundler/plugins

@thescientist13 thescientist13 changed the title feature/issue 953 validate support for Bun feature/issue 953 support for Bun Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI documentation Greenwood specific docs feature New feature or request question Further information is requested
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant