Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/issue 16 parallel serialization #216

Closed
wants to merge 2 commits into from
Closed

Enhancement/issue 16 parallel serialization #216

wants to merge 2 commits into from

Conversation

thescientist13
Copy link
Member

Related Issue

resolves #16 but seeing if / hoping it might help with #213 ? 🤷‍♂

Summary of Changes

  1. Maintain one instance of puppeteer while serializing all pages

Interestingly enough I thought this would be a big performance boost, but running yarn build didn't seem to improve all that much but maybe it will be faster in CI? It will least it help with this issue though

multple-puppeteers

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) chore unit testing, maintenance, etc labels Sep 30, 2019
@thescientist13 thescientist13 changed the base branch from master to release/0.4.0 October 1, 2019 23:25
@thescientist13 thescientist13 mentioned this pull request Oct 2, 2019
Closed
5 tasks
@thescientist13
Copy link
Member Author

resolved as part of #217

@thescientist13 thescientist13 deleted the enhancement/issue-16-parallel-serialization branch October 12, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore unit testing, maintenance, etc enhancement Improve something existing (e.g. no docs, new APIs, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13