Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix plugin-livereload per expected intercept return value #478

Merged
merged 1 commit into from
Feb 20, 2021
Merged

fix plugin-livereload per expected intercept return value #478

merged 1 commit into from
Feb 20, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 18, 2021 •
edited
Loading

Related Issue

#470

Summary of Changes

  1. realized that in the PR for Enhancement/issue 426 restore postcss as plugins #473, i should have updated the return value for plugin-livereload 🤦

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP labels Feb 18, 2021
@thescientist13 thescientist13 added CLI Plugins Greenwood Plugins labels Feb 18, 2021
@thescientist13 thescientist13 changed the title update live-reload plugin per expected intercept return value update plugin-livereload per expected intercept return value Feb 18, 2021
@thescientist13 thescientist13 changed the title update plugin-livereload per expected intercept return value fix plugin-livereload per expected intercept return value Feb 18, 2021
@thescientist13 thescientist13 linked an issue Feb 18, 2021 that may be closed by this pull request
extend a server api so that developers can call custom server plugins #470
Closed
5 tasks
@thescientist13 thescientist13 merged commit fe473c9 into release/0.10.0 Feb 20, 2021
@thescientist13 thescientist13 deleted the bug/issue-470-fix-regression-from-a-subsequent-rebase branch February 20, 2021 15:46
@thescientist13 thescientist13 mentioned this pull request Feb 20, 2021
Merged
12 tasks
thescientist13 added a commit that referenced this pull request Apr 3, 2021
@thescientist13
update live-reload plugin per expected intercept return value (#478)
1ac7ff5
thescientist13 added a commit that referenced this pull request Apr 3, 2021
@thescientist13
update live-reload plugin per expected intercept return value (#478)
a81e4bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutchgrant hutchgrant Awaiting requested review from hutchgrant

@aholtzman aholtzman Awaiting requested review from aholtzman

Assignees
No one assigned
Labels
alpha.5 bug Something isn't working CLI P0 Critical issue that should get addressed ASAP Plugins Greenwood Plugins v0.10.0
Projects
None yet
Milestone
No Bundle Feature Parity
Development

Successfully merging this pull request may close these issues.

extend a server api so that developers can call custom server plugins
1 participant
@thescientist13