Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle no bundling of remote URLs and add error handling for sync rollup hooks #494

Conversation

thescientist13
Copy link
Member

Related Issue

resolves #491

Summary of Changes

  1. Add error handing (try / catch) for synchronous rollup build hooks to address unhandled Promise reject error
  2. For rollup, avoid bundling remote URLs for <script> and <link> tags
  3. Added new test case

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI labels Mar 21, 2021
@thescientist13 thescientist13 linked an issue Mar 21, 2021 that may be closed by this pull request
5 tasks
@thescientist13 thescientist13 changed the title handle no bundling of remote URLs and add error handling for sync rol… handle no bundling of remote URLs and add error handling for sync rollup hooks Mar 26, 2021
@thescientist13 thescientist13 merged commit 8f54c19 into release/0.10.0 Mar 26, 2021
@thescientist13 thescientist13 deleted the bug/issue-491-handle-bundling-remote-urls-for-script-link-tags branch March 26, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<link> tags that reference remote URLs break the build (v0.10.0 alpha)
1 participant