Enhancement/issue 575 optional prerendering #580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #575
Summary of Changes
prerender
configuration option for bypassing puppeteerAt present and maybe not immediately obvious, but this feature is incompatible with using GraphQL from the client side since without running the web components, the *-cache.json files will never get created. As per #576 if we could do this entirely with HTML somehow or some sort of
<query-outlet></query-outlet>
that would be great? There are some options to explore for sure.It should be noted graph.json will still exist, so anyone can still use
fetch
to get the same information.That said, the site builds suuuuuuper fast without prerendering, in like 5-6s.
Thoughts / Issues To Make
prerender
options?browser
(default) - what we are doing currentlyRenderElement
- Lit's native solutionLitElement
- as a plugin, specifically for Lit?"mode"
TODOs
Upgrade config schema ?- not neededbuild
command