Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/issue 435 deeply nested relative paths #618

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented May 30, 2021

Related Issue

resolves #435

See for an example / reference - thegreenhouseio/www.thegreenhouse.io#215

Summary of Changes

  1. Added support for using relative paths ../ in templates for CSS / JS no matter the level of page nesting
  2. Refactored some common URL calculation methods into ResourceInterface
  3. Added test cases specifically for deeply nested pages and all relative path usage
  4. Updated website to use ../ consistently

TODO

  1. Update template docs recommendations accordingly (note: using absolution (/) is probably going to be marginally faster, fyi)
  2. Update consolidate all Greenwood standard plugin usage into one place #520 to have plugin-user-workspace defer resolution if another plugin "claims" to resolve (e.g. like node_modules instead of testing for it specifically)
  3. Noticed we are including our fonts twice; in app.html and theme.css. (app.html already includes theme.css). Will open a separate PR for this. - remove duplicate load of css font #619
  4. Fix Windows CI
  5. fix package.json loading on Windows - is its own issue not related to this PR import JSON via ESM for the website is not bundling correctly on Windows #620
  6. investigate local mono repo packages work around
  7. test front matter imports
  8. Make discussion around symlink work around for Greenwood development in rollup.config.js - remove local development symlink workaround from rollup.config.js #623

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) website Tasks related to the projects website / documentation documentation Greenwood specific docs CLI labels May 30, 2021
@thescientist13 thescientist13 self-assigned this May 30, 2021
@thescientist13 thescientist13 changed the title Enhancement/issue 435 relative paths in templates Enhancement/issue 435 deeply nested relative paths May 31, 2021
@thescientist13 thescientist13 marked this pull request as ready for review May 31, 2021 22:22
@thescientist13 thescientist13 removed their assignment Jun 5, 2021
@thescientist13 thescientist13 force-pushed the enhancement/issue-435-relative-paths-in-templates branch from 0110f6e to 1eeccde Compare June 5, 2021 15:42
@thescientist13 thescientist13 merged commit 91cdb2d into master Jun 5, 2021
@thescientist13 thescientist13 deleted the enhancement/issue-435-relative-paths-in-templates branch June 5, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) website Tasks related to the projects website / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolve (deeply) nested relative template paths to expected workspace path
1 participant