Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/dist command broken #93

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Aug 13, 2022

Related Issue

Running npm run dist is broken, seems related to #73

% npm run dist

> [email protected] dist
> rollup -c rollup.config.js


src/wcc.js → dist/wcc.dist.cjs...
[!] (plugin commonjs--resolver) Error: Unexpected token (Note that you need @rollup/plugin-json to import JSON files)
node_modules/escodegen/package.json (2:10)
1: {
2:     "name": "escodegen",
             ^
3:     "description": "ECMAScript code generator",
4:     "homepage": "http://github.com/estools/escodegen",
Error: Unexpected token (Note that you need @rollup/plugin-json to import JSON files)
    at error (/Users/owenbuckley/Workspace/project-evergreen/repos/wcc/node_modules/rollup/dist/shared/rollup.js:198:30)
    at Module.error (/Users/owenbuckley/Workspace/project-evergreen/repos/wcc/node_modules/rollup/dist/shared/rollup.js:12555:16)
    at Module.tryParse (/Users/owenbuckley/Workspace/project-evergreen/repos/wcc/node_modules/rollup/dist/shared/rollup.js:12932:25)
    at Module.setSource (/Users/owenbuckley/Workspace/project-evergreen/repos/wcc/node_modules/rollup/dist/shared/rollup.js:12837:24)
    at ModuleLoader.addModuleSource (/Users/owenbuckley/Workspace/project-evergreen/repos/wcc/node_modules/rollup/dist/shared/rollup.js:22311:20)

Summary of Changes

  1. Verify npm run dist during ci
  2. Resolved Rollup build issue

@thescientist13 thescientist13 linked an issue Aug 13, 2022 that may be closed by this pull request
@thescientist13 thescientist13 merged commit affd0e4 into master Aug 13, 2022
@thescientist13 thescientist13 deleted the chore/dist-command-broken branch August 13, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile JSX to custom element (proof of concept)
1 participant