Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks related to value class support in deserialization #211

Merged
merged 5 commits into from
Jan 21, 2024
Merged

Conversation

k163377
Copy link
Contributor

@k163377 k163377 commented Jan 21, 2024

Fixed minor flaws discovered through the porting process to jackson-module-kotlin.

  • Changed the name of ValueClassDeserializer to WrapsNullableValueClassDeserializer.
    • This is because it was thought to be misleading that it should be used for other than value class that wraps nullables.
  • Changed to use the return value of the creator when initializing the deserializer of value class.
    • This is because there was no problem with this form as long as the target is handled by KotlinModule.
    • However, since unboxConverter is used by Instantiator, the initialization cost does not change much.

@k163377 k163377 merged commit a2e9042 into develop Jan 21, 2024
3 checks passed
@k163377 k163377 deleted the fixes branch January 21, 2024 12:30
@github-actions github-actions bot mentioned this pull request Jan 21, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant