Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix broken logo images #3

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

brian-rose
Copy link
Member

Currently the logos at the top of the published notebooks are not appearing.

I think the reason is that jupyter-book / myst-nb are not handling the relative path corrections for the html img tags because they are wrapped in an html table.

Here I try to replace the html table with a markdown table instead to see if that fixes the problem.

The way jupyter-book handles html image tags is a bit confusing. We'll see in the PR preview if this helps.

@github-actions
Copy link

github-actions bot commented Jun 26, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 90c26c2
✅ Deployment Preview URL: https://ProjectPythia.github.io/ERA5_interactive-cookbook/_preview/3

@brian-rose brian-rose marked this pull request as ready for review June 26, 2023 21:58
@brian-rose
Copy link
Member Author

So it turns out that removing the <img> tags from the table fixed the problem of the missing images -- but it doesn't really look as nice this way.

It would be better to have more fine-grained control over image placement, but I don't know how to do that in a way that plays well with Jupyter Book.

@brian-rose brian-rose requested a review from ktyle June 26, 2023 22:00
Copy link
Collaborator

@ktyle ktyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brian-rose that will do for now.

@ktyle ktyle merged commit 2af2ebe into ProjectPythia:main Jun 27, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 27, 2023
@brian-rose brian-rose deleted the fix-logos branch June 27, 2023 16:36
negin513 pushed a commit that referenced this pull request Jun 14, 2024
Merge pull request #1 from NicholasCote/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants