Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute error in gallery action #167

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Attribute error in gallery action #167

merged 2 commits into from
Aug 7, 2023

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Jul 27, 2023

Action is failing with an attribute error - see #165

Run python .github/workflows/collect-user-submission.py
Traceback (most recent call last):
  File ".github/workflows/collect-user-submission.py", line 38, in <module>
    issue = IssueInfo(gh_event_path=os.environ["GITHUB_EVENT_PATH"]).create_submission()
  File ".github/workflows/collect-user-submission.py", line 23, in create_submission
    self._create_submission_input()
  File ".github/workflows/collect-user-submission.py", line 27, in _create_submission_input
    text = self.data["issue"]["body"]
AttributeError: 'IssueInfo' object has no attribute 'data'
Error: Process completed with exit code 1.

This is an attempt to update the .py script to fix this. Related to #158

@jukent jukent requested a review from a team as a code owner July 27, 2023 16:46
@jukent jukent requested review from ktyle and dcamron and removed request for a team July 27, 2023 16:46
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: ea1053a
✅ Deployment Preview URL: https://ProjectPythia.github.io/cookbook-gallery/_preview/167

@jukent jukent requested a review from r-ford August 3, 2023 15:52
Copy link
Member

@r-ford r-ford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jukent, I'm not familiar enough with the infrastructure to know if this will work, but I think it's probably fine to merge this to test it.

@brian-rose
Copy link
Member

I don't understand it much either, but since it's already broken, I don't see a good reason not to ahead and merge for further testing @jukent

@jukent
Copy link
Contributor Author

jukent commented Aug 7, 2023

Thank you. I'm not 100% confident but it it is a possible workaround if self.data doesn't exist. Let's merge and see.

@jukent jukent merged commit d09920a into ProjectPythia:main Aug 7, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants