Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how-to-cite to portal #344

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Add how-to-cite to portal #344

merged 3 commits into from
Aug 14, 2023

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Jul 26, 2023

Do we want how to cite in the long page or on a separate page?

I want to add this to the footer as well, but I think that is done in the sphinx-pythia-theme repo. I need to do more investigation on the cite infrastructure, but this is a good first step.

Please give your review on the text as well as location.

Related to #306

@jukent jukent requested a review from a team as a code owner July 26, 2023 20:35
@jukent jukent requested review from dopplershift and brian-rose and removed request for a team July 26, 2023 20:35
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: a68e7f1
✅ Deployment Preview URL: https://projectpythia.github.io/_preview/344

@jukent
Copy link
Contributor Author

jukent commented Jul 26, 2023

Screen Shot 2023-07-26 at 2 35 53 PM

Which section of the footer would it best fit in? I'm leaning towards under "About"

@jukent
Copy link
Contributor Author

jukent commented Jul 26, 2023

Similarly, do we want this in the top nav bar?

@jukent
Copy link
Contributor Author

jukent commented Jul 26, 2023

Looks like I'd have to change it in the portal, foundations, and cookbook gallery footer-menu:
https://github.com/ProjectPythia/projectpythia.github.io/blob/main/portal/_templates/footer-menu.html
https://github.com/ProjectPythia/pythia-foundations/blob/main/_templates/footer-menu.html
https://github.com/ProjectPythia/cookbook-gallery/blob/main/site/_templates/footer-menu.html

Looking at this, should we remove the discussions and replace with a link to Pangeo discourse?

@jukent jukent requested a review from a team as a code owner July 26, 2023 21:47
@jukent jukent requested review from ktyle and dcamron August 8, 2023 15:19
@jukent
Copy link
Contributor Author

jukent commented Aug 8, 2023

See ProjectPythia/cookbook-gallery#170 and ProjectPythia/pythia-foundations#418 for making these changes in Foundations and Cookbooks

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the location of the "How to Cite" section at the bottom of the single home page. It makes sense to me.

I notice a number of places where there are now dead links because we removed the Team section (#346). I'll open a new issue about that. Unfortunately our link checker doesn't fail on missing internal links to page anchors so there's no notification about that.

@jukent jukent merged commit 2a6cf31 into ProjectPythia:main Aug 14, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 14, 2023
@brian-rose
Copy link
Member

Opened #349 to track the newly broken links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants