-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookbook pre-review checklist template #451
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
6145e3f
to
9dff8c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @dcamron! Thanks for submitting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great! I made a few suggestions that I hope help clarify the expected order of events in most cases.
Co-authored-by: Brian Rose <[email protected]>
2ed9c68
to
7e3b527
Compare
This PR publishes a publicly viewable pre-review template for Cookbook authors. Our Cookbook "advocates" (shepherds in some discussions) should use this template as the checklist for a new issue in the Cookbooks they are supporting towards publication. We don't have a review process in place, but this should help get our hackathon Cookbooks published and serve as the baseline of the review process as we continue to develop it. The images won't resolve until this PR goes in, so below I've previewed what the checklist will look like with the current template in the PR:
PREVIEW BELOW
I am your Cookbook advocate, and my GitHub handle is . Please tag me in this issue with any problems getting your Cookbook published!
Once we've marked this entire checklist, click here to open an issue on ProjectPythia/cookbook-gallery to publish your Cookbook!
Take note especially of the Develop your cookbook, Authorship and the CITATION.cff file, and Gallery tags sections. Save the Generate a DOI step as the last step of this checklist.
If the template does not fit your Cookbook’s needs, that’s fine too! Simply let us know here in this issue.
We generally encourage the
<content>-cookbook
name structure.Specify the minimum number of packages needed to reproduce your content. Document any necessary conflicts and pinned package versions in an issue. In your Cookbook README or a content preamble, describe any unique dependencies handled outside the conda environment.
Declare any necessary prerequisite learning for each notebook at the top; these can be materials within your Cookbook, within other Cookbooks, or outside Project Pythia altogether.
Additionally, should your Cookbook reference other Cookbooks and learning materials to support your content? Could supporting content be added as updates to Foundations or other Cookbooks benefit your Cookbook?
trigger-replace-links
action provided to your Cookbook.This will update any links to the Cookbook template to refer to your finalized repository name. See Links that need updating for a new cookbook created from this template cookbook-template#183 for manual references to these links if needed.
trigger-replace-links
action in the workflows sidebar.This will serve as your Cookbook homepage
This can be seen in individual Pull Requests as green checkmarks ✅ for important automation, especially the trigger-book-build action. You can also view a historical list of any of these Actions in the Actions tab at the top of your Cookbook repository. Check out nightly-build and trigger-book-build of PRs, then the build/build jobs to identify code errors. Please comment in this thread if you have issues identifying the source of any build and publishing failures your Cookbook has. Common failures include
This can be one or more people with availability to check in on this Cookbook, issue fixes to broken content, or with a vision for the future development of the Cookbook. This is typically (but not necessarily) one of the primary authors of the Cookbook.
Follow steps 1-4 under Generate a DOI in the Cookbook Guide. Return here for instructions on step 5, and your final step:
Publish release
!