Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

Fix can't accept Quests for Worgen Quest Line #936

Merged
merged 1 commit into from
Sep 26, 2013
Merged

Fix can't accept Quests for Worgen Quest Line #936

merged 1 commit into from
Sep 26, 2013

Conversation

Baeumchen
Copy link
Contributor

This will fix, that you can't accept some Quests on Worgen Quest Line (start). Pull request as wished in commit:

#853 (comment)

SkyFire added a commit that referenced this pull request Sep 26, 2013
Fix can't accept Quests for Worgen Quest Line
@SkyFire SkyFire merged commit f22cca8 into ProjectSkyfire:master Sep 26, 2013
@SkyFire
Copy link
Member

SkyFire commented Sep 26, 2013

Seems to work just fine. Merged.

@Baeumchen
Copy link
Contributor Author

As i noticed there are even more Quests, which needs fixed. I tested the Night elf Starting area and there are the same Problem. Also i'm working on a new pet system. Primary i'll do the Pet system and while testing i'll do the Quests in the spawn areas... Will take a while :)

@Raydeon
Copy link
Contributor

Raydeon commented Jan 3, 2014

I don't think this is a proper fix... why would you change starting area quests to "sharable"? Flag 8 = sharable. These quests are NOT sharable. The quest flags for this particular quest are actually correct in the database. It should be flags 524288 (QUEST_FLAGS_AUTO_ACCEPT) + 262144 (QUEST_FLAGS_OBJ_TEXT) = 786432... which is what they are set at in the db before this fix. The problem is that skyfire's flags in the core are not correct. We should really revert this, as I personally sniffed every quest in the worgen area to get the correct flags and info during 4.0.6. The flags were right.

@testingwalker
Copy link

This was fixed the during the merge. I do agree with Raydeon, you don't want quest to be sharable in starting area, I believe the database in the skyfire's flag that needs fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants