-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(GODT-1619): Per connection metadata storage
This patch adds features to the gluon so that we can store per connection metadata. This is required to implement the IMAP ID extension, where we need to store IMAP client identifiers for each of the incoming connections. To achieve this we queue operations onto the queue which create, delete and store values in this storage space. This guarantees the operations are in sync with any potential future IMAP commands. This patch also updates the data written to disk to include the metadate storage in order for serialized commands that haven't been execute to function correctly. This patch also addresses a bug in pchan.go related to concurrent access after queue closing (thanks @james). Finally this patch also address some issues in pchan reported by golangcli-run.
- Loading branch information
1 parent
507ee09
commit bf2f1c3
Showing
29 changed files
with
461 additions
and
140 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,10 @@ func main() { | |
| logrus.WithError(err).Fatal("Failed to make temporary directory") | ||
| } | ||
|
|
||
| server := gluon.New(filepath.Join(dir, "server")) | ||
| server, err := gluon.New(filepath.Join(dir, "server")) | ||
| if err != nil { | ||
| logrus.WithError(err).Fatal("Failed to create server") | ||
| } | ||
|
|
||
| connector := connector.NewDummy( | ||
| []string{"[email protected]", "[email protected]"}, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| package remote | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "encoding/gob" | ||
| ) | ||
|
|
||
| type ConnMetadataID uint32 | ||
|
|
||
| // connMetadataStore provides a storage container for any type of data that needs to be associated to a connection. | ||
| type connMetadataStore struct { | ||
| data map[ConnMetadataID]map[string]any | ||
| } | ||
|
|
||
| func newConnMetadataStore() connMetadataStore { | ||
| return connMetadataStore{ | ||
| data: make(map[ConnMetadataID]map[string]any), | ||
| } | ||
| } | ||
|
|
||
| func (c *connMetadataStore) CreateStore(id ConnMetadataID) { | ||
| c.data[id] = make(map[string]any) | ||
| } | ||
|
|
||
| func (c *connMetadataStore) DeleteStore(id ConnMetadataID) { | ||
| delete(c.data, id) | ||
| } | ||
|
|
||
| func (c *connMetadataStore) GetActiveStoreIDs() []ConnMetadataID { | ||
| var values []ConnMetadataID | ||
|
|
||
| for k, _ := range c.data { | ||
| values = append(values, k) | ||
| } | ||
|
|
||
| return values | ||
| } | ||
|
|
||
| func (c *connMetadataStore) SetValue(id ConnMetadataID, key string, value any) bool { | ||
| valueStore, ok := c.data[id] | ||
|
|
||
| if !ok { | ||
| return false | ||
| } | ||
|
|
||
| valueStore[key] = value | ||
|
|
||
| return true | ||
| } | ||
|
|
||
| func (c *connMetadataStore) GetValue(id ConnMetadataID, key string) any { | ||
| valueStore, ok := c.data[id] | ||
|
|
||
| if !ok { | ||
| return false | ||
| } | ||
|
|
||
| value, ok := valueStore[key] | ||
|
|
||
| if !ok { | ||
| return nil | ||
| } | ||
|
|
||
| return value | ||
| } | ||
|
|
||
| func (c *connMetadataStore) MarshalBinary() ([]byte, error) { | ||
| buf := new(bytes.Buffer) | ||
|
|
||
| if err := gob.NewEncoder(buf).Encode(c.data); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return buf.Bytes(), nil | ||
| } | ||
|
|
||
| func (c *connMetadataStore) UnmarshalBinary(data []byte) error { | ||
| return gob.NewDecoder(bytes.NewReader(data)).Decode(&c.data) | ||
| } | ||
|
|
||
| func init() { | ||
| gob.Register(&connMetadataStore{}) | ||
| } |
Oops, something went wrong.