Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Move integration tests to CircleCI #28414

Merged
merged 49 commits into from
Nov 3, 2024
Merged

[CI] Move integration tests to CircleCI #28414

merged 49 commits into from
Nov 3, 2024

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Oct 21, 2024 •
edited
Loading

This PR moves integration tests to CircleCI, which supports ssh debugging.

Closes #28391

@acoglio acoglio self-requested a review October 28, 2024 16:42
mikebenfield
mikebenfield approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@mikebenfield mikebenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one thing I'll mention is that it seems now all CI builds use the only_testnet feature. Maybe that's OK, but OTOH maybe we want at least one build to not use that feature, so we can be sure everything at least compiles.

@d0cd d0cd merged commit 180bd99 into mainnet Nov 3, 2024
10 checks passed
@d0cd d0cd deleted the ci/integration-tests-to-circle-ci branch November 3, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendyarm bendyarm bendyarm approved these changes

@acoglio acoglio acoglio approved these changes

@mikebenfield mikebenfield mikebenfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] CI takes too long to run, consider splitting tests to make this faster
4 participants
@d0cd @mikebenfield @acoglio @bendyarm