Use httr::modify_url() in favour of custom code
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Moohan
added a commit
to Moohan/phsopendata
that referenced
this pull request
Sep 26, 2024
This is no longer needed thanks to Public-Health-Scotland#25
Moohan
added a commit
to Moohan/phsopendata
that referenced
this pull request
Sep 26, 2024
This is no longer needed thanks to Public-Health-Scotland#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on #24 I was distracted by the custom code that was creating the required URLs,
httrprovides a function to do thismodify_url(), so I've used that instead which I think should be easier to read and at least makes it more consistent across the package now!All tests pass, there should be no user-facing changes whatsoever.