Move some dependencies to suggests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moohan
force-pushed
the
dependencies/move_to_suggests
branch
from
1528465
to
f6a1132
Compare
csillasch
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed on the R CMD check action it was giving a NOTE that
xmlreadrandjsonlitewere imported but not used - I don't get this NOTE in RStudio so I suspect it's something that's been introduced in a version of R newer than the one we're currently using (4.1.0).These packages are only used in the tests, so they are not required dependencies for users. This PR moves them to the
Suggestsfield. I also picked some sensible minimum versions for the other dependencies which don't currently have them.