Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses check_all_pending! instead of check_pending! per ActiveRecord re… #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

broosk1993
Copy link

@broosk1993 broosk1993 commented Oct 4, 2023

Uses check_all_pending! instead of check_pending! per ActiveRecord recommendation.

ActiveRecord now shows a warning that check_all_pending! should be used.

@sharz1
Copy link

sharz1 commented Jan 12, 2024

Also running into this warning with rails 7 upgrade. Can this be merged as part of #123 resolution?

@c960657
Copy link

c960657 commented Feb 12, 2024

I suspect that calling check_all_pending! will cause random errors as those reported here:

The problem is hard to reproduce, but it seem to have gone away after I moved from the solution suggested here to calling ActiveRecord::Base.connection.migration_context.needs_migration? directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants