Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stored Bee API #1343

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Stored Bee API #1343

merged 6 commits into from
Jun 26, 2023

Conversation

EOT3000
Copy link
Contributor

@EOT3000 EOT3000 commented Jun 11, 2023

Adds a way to modify some properties of individual stored entities (bees in beehive), as well as release them individually, without having to release them all.

With requested changes.

theomega24
theomega24 requested changes Jun 11, 2023
View reviewed changes
Copy link
Member

@theomega24 theomega24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace stuff is largely just to make the diff smaller and more maintainable for us, nothing against your code style.

patches/server/0307-Stored-Bee-API.patch Outdated Show resolved Hide resolved
patches/server/0307-Stored-Bee-API.patch Outdated Show resolved Hide resolved
patches/server/0307-Stored-Bee-API.patch Outdated Show resolved Hide resolved
patches/server/0307-Stored-Bee-API.patch Outdated Show resolved Hide resolved
patches/server/0307-Stored-Bee-API.patch Outdated Show resolved Hide resolved
patches/server/0307-Stored-Bee-API.patch Outdated Show resolved Hide resolved
patches/server/0307-Stored-Bee-API.patch Outdated Show resolved Hide resolved
patches/api/0051-Stored-Bee-API.patch Outdated Show resolved Hide resolved
patches/server/0307-Stored-Bee-API.patch Outdated Show resolved Hide resolved
patches/server/0307-Stored-Bee-API.patch Outdated Show resolved Hide resolved
@EOT3000
Copy link
Contributor Author

EOT3000 commented Jun 12, 2023

Done.

@theomega24 theomega24 requested a review from granny June 14, 2023 23:04
@granny granny changed the base branch from ver/1.20 to ver/1.20.1 June 25, 2023 23:49
granny
granny approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@granny granny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For future reference make sure to create a new branch specifically for the PR you're creating instead of committing directly to the ver/... branch.

@granny granny merged commit db86b6e into PurpurMC:ver/1.20.1 Jun 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomega24 theomega24 theomega24 requested changes

@granny granny granny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EOT3000 @granny @theomega24