Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover lines API #1440

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Add hover lines API #1440

merged 2 commits into from
Oct 4, 2023

Conversation

MelnCat
Copy link
Contributor

@MelnCat MelnCat commented Oct 3, 2023

This pull request adds a method on ItemStack to get the hover lines. This is the text shown when hovering over the item, which includes the item name, enchantments, and other information shown on hover. There is also an argument for showing the advanced tooltips, which functions like viewing the item on a client with F3 + H on.

Copy link
Member

@granny granny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one change, otherwise lgtm

patches/server/0304-Add-hover-lines-API.patch Outdated Show resolved Hide resolved
@granny granny merged commit c5eadcc into PurpurMC:ver/1.20.2 Oct 4, 2023
1 check passed
Comstepr added a commit to Comstepr/Purpur that referenced this pull request Oct 4, 2023
* Updated Upstream (Paper)

Upstream has released updates that appear to apply and compile correctly

Paper Changes:
PaperMC/Paper@f6969b6 Updated Upstream (Bukkit/CraftBukkit/Spigot)
PaperMC/Paper@bb1c0dd Implement tracking range y setting
PaperMC/Paper@9d21a88 Fix tests
PaperMC/Paper@6573d95 update configurate (#9230)
PaperMC/Paper@f36bb59 Fix entity data not updated for firework attached to entity (#9783)

* Add hover lines API (PurpurMC#1440)

* temporarily comment out javadoc.io links in javadoc

* missed one of the links

---------

Co-authored-by: granny <[email protected]>
Co-authored-by: Melncat <[email protected]>
vortexthedev pushed a commit to vortexthedev/Purpur that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants