-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mansion only totem drops #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to include ignoreCancelled and priority in your @ EventHandler annotations
I don't want to be ignoring cancelled events here afaik - and isn't |
We do want both. Default behavior for ignoreCancelled is false, so it fires every time regardless of cancellation state. We don't want to add or remove raiders if their wave spawn or death were cancelled, because, well, the didn't die or spawn |
i'm ngl my entire time bukkit coding my brain just assumed by default cancelled events weren't processed nice |
still untested but fixed annotations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use event
isntead of ev
in listeners for sake of consistency with all other modules.
It's also missing the annotation documenting what it does
forgot to comment - this was fixed up |
src/main/java/org/purpurmc/purpurextras/modules/RaidTotemDropsModule.java
Outdated
Show resolved
Hide resolved
no longer using concurrent hashmap |
Marked as a draft cause I feel like this is gonna be a pain to test so I haven't tested it yet, the logic looks fine though
Adds #49