Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mansion only totem drops #56

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

TheRealRyGuy
Copy link
Contributor

Marked as a draft cause I feel like this is gonna be a pain to test so I haven't tested it yet, the logic looks fine though
Adds #49

@TheRealRyGuy TheRealRyGuy marked this pull request as draft June 15, 2023 14:53
Copy link
Member

@YouHaveTrouble YouHaveTrouble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to include ignoreCancelled and priority in your @ EventHandler annotations

@TheRealRyGuy
Copy link
Contributor Author

I don't want to be ignoring cancelled events here afaik - and isn't EventPriority#NORMAL default? seems unnecessary

@YouHaveTrouble
Copy link
Member

I don't want to be ignoring cancelled events here afaik - and isn't EventPriority#NORMAL default? seems unnecessary

We do want both. Default behavior for ignoreCancelled is false, so it fires every time regardless of cancellation state. We don't want to add or remove raiders if their wave spawn or death were cancelled, because, well, the didn't die or spawn

@TheRealRyGuy
Copy link
Contributor Author

TheRealRyGuy commented Jun 15, 2023

i'm ngl my entire time bukkit coding my brain just assumed by default cancelled events weren't processed

nice

@TheRealRyGuy
Copy link
Contributor Author

still untested but fixed annotations

@TheRealRyGuy TheRealRyGuy marked this pull request as ready for review June 15, 2023 23:02
Copy link
Member

@YouHaveTrouble YouHaveTrouble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use event isntead of ev in listeners for sake of consistency with all other modules.
It's also missing the annotation documenting what it does

@TheRealRyGuy
Copy link
Contributor Author

forgot to comment - this was fixed up

@TheRealRyGuy
Copy link
Contributor Author

no longer using concurrent hashmap

@YouHaveTrouble YouHaveTrouble merged commit d238286 into PurpurMC:master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants