More than 6 banner layers #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"complexity" thank you codefactor for explaining what's wrong with the code really helpful |
|
Will this even work? Last time I checked there was a client limit on this and it refused to send packets for clicks in the gui with banners over layer limit |
It removes all the first layers before the 6 last layers in the input slot and brings them back in the output slot with the new edits |
YouHaveTrouble
requested changes
Jun 18, 2023
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/BannerLayersModule.java
Outdated
Show resolved
Hide resolved
YouHaveTrouble
requested changes
Jun 25, 2023
src/main/java/org/purpurmc/purpurextras/modules/LoomMaxLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/LoomMaxLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/LoomMaxLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/LoomMaxLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/LoomMaxLayersModule.java
Outdated
Show resolved
Hide resolved
src/main/java/org/purpurmc/purpurextras/modules/LoomMaxLayersModule.java
Outdated
Show resolved
Hide resolved
YouHaveTrouble
requested changes
Jul 25, 2023
|
yes sir 🫡 |
YouHaveTrouble
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds option to have more than 6 banner layers