-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django sql injection #292
Django sql injection #292
Conversation
looks good to me, will let either @ericwb or @sigmavirus24 be approving reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this locally, but it looks (:eyes: - only) good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I was late to review. There are a couple things to fix up, hopefully soon in a future PR.
|
||
|
||
import ast | ||
import bandit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a blank line before this import. Pep8 says to group imports.
- https://docs.djangoproject.com/en/dev/topics/ | ||
security/#sql-injection-protection | ||
|
||
.. versionadded:: X.X.X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be set to 1.4.1
- https://docs.djangoproject.com/en/dev/topics/ | ||
security/#sql-injection-protection | ||
|
||
.. versionadded:: X.X.X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be set to 1.4.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need autodoc link to these new plugins. See https://github.com/PyCQA/bandit/tree/master/doc/source/plugins
Done issue #291