-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove OpenStack-specific plugins #316
Conversation
Fixes: #296 Signed-off-by: nickthetait <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples/secret-config-option.py and examples/exec-as-root.py should also be removed.
|
||
.. automodule:: bandit.plugins.exec_as_root | ||
This plugin has been deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should say removed, not deprecated. Deprecated implies it still works and will be removed in the future.
|
||
.. automodule:: bandit.plugins.secret_config_option | ||
This plugin has been deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should say removed, not deprecated. Deprecated implies it still works and will be removed in the future.
Signed-off-by: nickthetait <[email protected]>
Fixed 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go. Thanks for your efforts addressing all my comments.
(same as #311 but excluding commits I wasn't trying to add)