Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenStack-specific plugins #316

Merged
merged 3 commits into from
Jun 9, 2018
Merged

Remove OpenStack-specific plugins #316

merged 3 commits into from
Jun 9, 2018

Conversation

nickthetait
Copy link

(same as #311 but excluding commits I wasn't trying to add)

Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/secret-config-option.py and examples/exec-as-root.py should also be removed.


.. automodule:: bandit.plugins.exec_as_root
This plugin has been deprecated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should say removed, not deprecated. Deprecated implies it still works and will be removed in the future.


.. automodule:: bandit.plugins.secret_config_option
This plugin has been deprecated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should say removed, not deprecated. Deprecated implies it still works and will be removed in the future.

@nickthetait
Copy link
Author

Fixed 😄

Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. Thanks for your efforts addressing all my comments.

@ericwb ericwb merged commit d93eed5 into PyCQA:master Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants