-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password #387
Password #387
Conversation
@sigmavirus24 I also fix a bug on this rule on python2 (d90eecf) when the param is a list, for example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of using regex here, but with this current patch I don't think it adds a great deal - its just the same list as before, but using re. instead of a python list.
However I think it would be really nice to have the option of providing the list externally so users could supply there own. Something like [0] maybe - although that list might not be a good example as it would cause performance issues.
So an external list would be sourced and fed into re.compile (or if no list is present just use the defaults in the code). Perhaps the list could be configured in the config parser, if its present (true) then load the list, if not (false) use the defaults.
What do you think?
Hi @lukehinds I like your idea, however the flow that you describe I think should be a new requirement out of this rule. |
@ehooo understood if you would like to work on that, please go ahead and raise it as an enhancement. |
Proposed solution for #386 with re