check if ast.JoinedStr exists before using it #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ast.JoinedStr is new in Python3.6 (it's f-strings), it does not exist in Pythons below that
ericwb
approved these changes
Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line with
isinstance(..., ast.JoinedStr)was added in d237448 for #427.ast.JoinedStris new in Python3.6 (it's f-strings), it does not exist in Pythons below that, so this is anAttributeError: 'module' object has no attribute 'JoinedStr'for Python<3.6.I'm not sure why travis didn't raise this as an issue, I'm not too familiar with the test suite here so let me know if there's a test that can be added for this.